Avoid race between visit tests #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurboDriveTestCase maintains a eventLogChannel that acts as a cursor for the page's window.eventLogs array. Before every test the eventLogChannel is drained by reading all events and its internal index (cursor) is updated accordingly. The race was happening when we changed the page location and not blocking on it: the eventLogChannel was draining the previous page bumping its internal index. After the page was reload that index was out of sync since the new page had an new, empty eventLogs array. Order of events * async location change * draining eventLogChannel on the previous page * actual location change * eventLogChannel is out-of-sync This is was fixed as part of hotwired#289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TurboDriveTestCase maintains a eventLogChannel that acts as a cursor
for the page's window.eventLogs array. Before every test the
eventLogChannel is drained by reading all events and its internal
index (cursor) is updated accordingly.
The race was happening when we changed the page location and not
blocking on it: the eventLogChannel was draining the previous page
bumping its internal index. After the page was reload that index was
out of sync since the new page had a new, empty eventLogs array.
Order of events
This was fixed as part of #289