Skip to content

Conversation

@jferris
Copy link
Contributor

@jferris jferris commented Dec 22, 2014

  • Multiple statuses with the same context overwrite each other
  • We only want Hound to overwrite Hound status
  • Removes "default" text from GitHub UI

https://developer.github.com/v3/repos/statuses/

@salbertson
Copy link
Member

A lot simpler than #516. 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth extracting this into a constant?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wonder if this should be houndci for parity with the user that makes the comments.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We rarely use houndci, I think hound is fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "rarely"? Our github, twitter, and internet address are all houndci.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean rarely in any of the blog posts or marketing copy. CI was included in things you listed because the names and domain weren't available without it.

@gylaz
Copy link
Member

gylaz commented Dec 22, 2014

I'm 👍 on this, though I closed #517 in favor of #516.

@jferris
Copy link
Contributor Author

jferris commented Dec 22, 2014

Sorry, I didn't notice either #516 or #517. You are welcome to merge whichever one you think is appropriate.

@gylaz
Copy link
Member

gylaz commented Dec 22, 2014

The other two are closed already, so let's merge this one!

@Razer6
Copy link

Razer6 commented Dec 29, 2014

👍

@salbertson
Copy link
Member

@jferris, what is left to get this merged?

@jferris jferris merged commit 83a4e3e into master Jan 5, 2015
@jferris jferris force-pushed the jf-github-status-context branch from e3e7a29 to 83a4e3e Compare January 5, 2015 15:59
@jferris jferris deleted the jf-github-status-context branch January 5, 2015 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants