-
Notifications
You must be signed in to change notification settings - Fork 394
Set a context when sending status to GitHub #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A lot simpler than #516. 👍 |
lib/github_api.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth extracting this into a constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also wonder if this should be houndci for parity with the user that makes the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We rarely use houndci, I think hound is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by "rarely"? Our github, twitter, and internet address are all houndci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean rarely in any of the blog posts or marketing copy. CI was included in things you listed because the names and domain weren't available without it.
|
The other two are closed already, so let's merge this one! |
|
👍 |
|
@jferris, what is left to get this merged? |
e3e7a29 to
83a4e3e
Compare
https://developer.github.com/v3/repos/statuses/