Improve level validation and canonicalisation logic #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having started working on RT bug #106495, I subsequently realised that the issue
had been resolved with GitHub PR #15. As I have a handful of modest improvements
left over from this work, I figured that I might as well submit them.
Note that this patch addresses the following discrepancy:-
numbers, not just names
looks like an unsigned integer of any length [1]
level_is_valid() [2]
does not look like an unsigned integer of any length [1]
so that we can continue to throw user-friendly exceptions where min_level or
max_level are specified incorrectly
[1] DRY principle; validation having already been conducted by level_is_valid()
[2] Establishes symmetry with _level_as_number(), which also validates