Adds plugin to support Perl::Tidy::Sweetened #14

Closed
wants to merge 6 commits into
from

2 participants

@mvgrimes

Perl::Tidy::Sweetened is a code tidier, built on Perl::Tidy, that
supports the new syntactic sugar for OO and method signatures as
provided by LMethod::Signature::Simple, LMooseX::Method::Signatures
and the p5-mop.

This patch creates a plugin to support Perl::Tidy::Sweetened
under Code::TidyAll.

Thanks,
Mark

@mvgrimes mvgrimes Adds plugin to support Perl::Tidy::Sweetened
Perl::Tidy::Sweetened is a code tidier, built on Perl::Tidy, that
supports the new syntactic sugar for OO and method signatures as
provided by L<Method::Signature::Simple>, L<MooseX::Method::Signatures>
and the p5-mop.
abbd08a
@autarch

This looks good to me, but I think it'd be better named "perltidysweetened" rather than "perltidier". The latter name is way too close to "perltidy" and doesn't really give any indication of how it's different.

@mvgrimes mvgrimes Renames PerlTidier to PerlTidySweet
- More clearly differentiates from PerlTidy. Thanks to Dave Rolsky for
  the recommendation.
c9d722d
@mvgrimes

Good idea. I went with perltidy-sweet, and patched the pull request.

@autarch autarch commented on the diff Dec 20, 2014
lib/Code/TidyAll/Plugin/PerlTidySweet.pm
@@ -0,0 +1,76 @@
+package Code::TidyAll::Plugin::PerlTidySweet;
@autarch
autarch added a line comment Dec 20, 2014

You need to add a blank line after the package statement for the benefit of dzil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@autarch

I'll merge this once Travis passes. I made a comment explaining why it's failing.

@autarch autarch commented on an outdated diff Dec 22, 2014
lib/Code/TidyAll/t/Plugin/PerlTidier.pm
@@ -0,0 +1,37 @@
+
+package Code::TidyAll::t::Plugin::PerlTidier;
@autarch
autarch added a line comment Dec 22, 2014

You also need a blank line here to make dzil happy.

BTW, feel free to rebase all the changes together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@autarch

I finally got the test suite passing in travis (the blead failure is not because of this distro). If you rebase off master and push we can see if your branch passes too.

@autarch

Looks like you submitted this as a separate PR (you can force push to an existing PR, just so you know). I'll close this one.

@autarch autarch closed this Dec 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment