New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests pass with plain prove #92

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@HaraldJoerg
Contributor

HaraldJoerg commented Jul 5, 2018

When I run the tests from the repository with prove -vlbr, then two tests (basic.tand test_control_methods) have one failure each. The failure disappears when I directly call prove -vlbr t/basic.t. Apparently prove without a path prepends ./t/ before the test files: the failure reappears when I call prove -vlbr ./t/basic.t. The patch allows for an optional ./ before the path names in the die messages.
make test passes with and without the patch.

This PR is a "side effect" of my work with test-class-moose as my July assignment in the CPAN Pull Request Challenge.

@autarch

Thanks for working on this. I think this can be simplified, however.

Show outdated Hide outdated t/basic.t
Show outdated Hide outdated t/test_control_methods.t
@HaraldJoerg

This comment has been minimized.

Show comment
Hide comment
@HaraldJoerg

HaraldJoerg Jul 6, 2018

Contributor

Agreed, and adjusted accordingly.

Contributor

HaraldJoerg commented Jul 6, 2018

Agreed, and adjusted accordingly.

@autarch

This comment has been minimized.

Show comment
Hide comment
@autarch

autarch Jul 7, 2018

Contributor

Merged from the CLI. Thanks!

Contributor

autarch commented Jul 7, 2018

Merged from the CLI. Thanks!

@autarch autarch closed this Jul 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment