Styled Navbar #21
Styled Navbar #21
Conversation
|
Deploy preview for houseofgeeks ready! Built with commit 4ac7fec |
|
There was a problem hiding this comment.
This PR will be merged only after #20 is merged. Avoid changing Navbar.js to minimize conflicts later. The build is looking beautiful.. Good job @hariom1625 ! 🤩
client/src/components/Home/Home.css
Outdated
| @@ -0,0 +1,4 @@ | |||
| .lander-img{ | |||
| width:auto; | |||
| height: auto; | |||
There was a problem hiding this comment.
Do take care of the indentation.
There was a problem hiding this comment.
As I postscript 😅 the cover image was for illustration purpose so I didn't decor that code as I haven't started working on that. Will fix that :-)
| function Home() { | ||
| return ( | ||
| <div className="home-component"> | ||
| <h1>This is the Home page.</h1> | ||
| <img className="lander-img img-fluid" src={shadow} alt="lander"/> |
There was a problem hiding this comment.
Using react-lazyload would help (I guess) as suggested by @ankiiitraj
There was a problem hiding this comment.
Will make use of it from next time, it was only for visualizing the navbar with a background other than white :-)
| margin-left: 20px; | ||
| padding-left: 35px; | ||
| } |
There was a problem hiding this comment.
Stick the closing parenthesis to the margin here.
| bottom: 19px; | ||
| height: 19px; | ||
| } |
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
Do correct the indentation of parenthesis in the media querries. It should be clear where the querry is ending.
There was a problem hiding this comment.
Good to go! 🥳 Waiting for #20 to get merged. Do change the title for this PR for avoiding confusion.
|
some conflicts and you're ready to go |
I have resolved the conflicts you can review the changes now :-) |
|
nice work @hariom1625 |
Thank you sir. |
Solves Issue #16
Description: Styled the Navbar as proposed in the wireframe.
PS: The cover image is being added only for illustration purpose.
Checklist