Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added preloader #85

Merged
merged 1 commit into from
Sep 25, 2020
Merged

added preloader #85

merged 1 commit into from
Sep 25, 2020

Conversation

ankiiitraj
Copy link
Member

@ankiiitraj ankiiitraj commented Sep 25, 2020

fixes #60

Description: Simple preloader, can be modified if something better in option!

Checklist

  • I've followed the Contributing guidelines provided in the repository.
  • I've made the changes that were demanded in the linked issue.
  • I've tested my code on a Chromium-based browser.
  • I've tested my code on Mozilla Firefox.
  • My code gave a clean console on debugging. (no warnings/errors)

Testimonial

N/A

@ankiiitraj ankiiitraj requested review from EmperorYP7 and tusharjain0022 and removed request for EmperorYP7 September 25, 2020 00:02
@netlify
Copy link

netlify bot commented Sep 25, 2020

Deploy preview for houseofgeeks ready!

Built with commit a527cb9

https://deploy-preview-85--houseofgeeks.netlify.app

added preloader
@ankiiitraj
Copy link
Member Author

To see the preloader in action, go to the console and then to network and choose regular 2G in throttling!

@hariom1625
Copy link
Member

Loved it !!

Copy link
Member

@tusharjain0022 tusharjain0022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing !! LGTM! 🤩

Copy link
Member

@EmperorYP7 EmperorYP7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. let's get this fired up! 🤩

@ankiiitraj ankiiitraj merged commit 1babaaa into houseofgeeks:front-end Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants