Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Set default tray icon to color (or add option for light tray icon) #393

Closed
pedlino opened this issue Apr 17, 2019 · 6 comments

Comments

@pedlino
Copy link

@pedlino pedlino commented Apr 17, 2019

Prerequisites

  • I'm using latest version: v 0.19.1
  • I've checked Known issues: Yes

Description

[Description of the issue]
If the user has a transparent tray (default on Ubuntu 18.04) the black monochrome tray icon can become invisible (depending on the color of the background image)

An easy way to test this is setting the background to single Color = Black

Operating system: Ubuntu 18.04 x64

Expected behavior: Tray icon is visible

Actual behavior: Tray icon is invisible (black icon on black background)

Reproduces how often: [What percentage of the time does it reproduce?]

Additional Information

My suggestion is to set the color tray icon as default (switching to monochrome can be easily done in the Settings). This solves the problem with same color background.
Another additional suggestion is to have three icon tray options: light, dark and color (which would also be a workaround for Bug #322 )

@hovancik

This comment has been minimized.

Copy link
Owner

@hovancik hovancik commented Apr 17, 2019

Hi,

you can set to "colorful icon" is settings on 3th page

image

I'm using it on my debian sid ;]

image

there are too many DEs on Linux and too many tray implementations. The best way forward would be to report issues on different DEs and ask them to support what macOS is doing: I give it monochrome icon and it changes to the best color for tray auto-magically.

@hovancik hovancik closed this Apr 17, 2019
@pedlino

This comment has been minimized.

Copy link
Author

@pedlino pedlino commented Apr 17, 2019

you can set to "colorful icon" is settings on 3th page

Yes, I had already done that.
My suggestion was that to set the color icon as Default and the user could manually switch to either a dark or light monochrome icon if he/she didn't like the colored icon.

there are too many DEs on Linux and too many tray implementations. The best way forward would be to report issues on different DEs and ask them to support what macOS is doing: I give it monochrome icon and it changes to the best color for tray auto-magically.

I agree. That is one of the main advantages of Apple hardware+software solutions.
Could you add a manual option for those who don't have auto-magic? ;)

@hovancik hovancik reopened this Apr 17, 2019
@hovancik

This comment has been minimized.

Copy link
Owner

@hovancik hovancik commented Apr 19, 2019

I have not done any of the graphics, so I will need help with this, but yeah, why not allow user to choose from more icons.

@hovancik

This comment has been minimized.

Copy link
Owner

@hovancik hovancik commented Oct 8, 2019

Added in #476

@hovancik hovancik closed this Oct 8, 2019
@pedlino

This comment has been minimized.

Copy link
Author

@pedlino pedlino commented Oct 14, 2019

Tested in 0.21. It works perfectly!
Thank you for listening and for adding the option!
Best regards from Faro, Portugal

@hovancik

This comment has been minimized.

Copy link
Owner

@hovancik hovancik commented Oct 15, 2019

Awesome, glad it works ;] And thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.