Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dutch translations #485

merged 2 commits into from Oct 11, 2019


Copy link

sheriallis commented Oct 11, 2019

closes #390


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • issue was opened to discuss proposed changes before starting implementation.
  • during development, node version specified in package.json was used (ie using nvm).
  • package versions and package-lock.json were not changed (npm install --no-save).
  • app version number was not changed.
  • all new code has tests to ensure against regressions.
  • npm run lint reports no offenses.
  • npm run test is error-free.
  • README and CHANGELOG were updated accordingly.

Description of the Change

Updated the Dutch translations in app/locales/nl.json. Also updated the README and CHANGELOG.

Verification Process

Other information


This comment has been minimized.

Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #485 into master will decrease coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
- Coverage   77.25%   76.82%   -0.43%     
  Files          11       11              
  Lines         233      233              
- Hits          180      179       -1     
- Misses         53       54       +1
Impacted Files Coverage Δ
app/utils/untilMorning.js 95.23% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f94a22e...0d9f7fc. Read the comment docs.


This comment has been minimized.

Copy link

hovancik commented Oct 11, 2019

@sheriallis there is this string untranslated: "useMonochromeInvertedTrayIcon": "invert monochrome tray icon",

can you translate that as well?


This comment has been minimized.

Copy link
Contributor Author

sheriallis commented Oct 11, 2019

I missed that one, I just added it. :)

@hovancik hovancik merged commit 5b0cdc2 into hovancik:master Oct 11, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/project 76.82% (-0.43%) compared to f94a22e
codeclimate All good!
codecov/patch Coverage not affected when comparing f94a22e...0d9f7fc
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@sheriallis sheriallis deleted the sheriallis:fix/update-dutch-translations branch Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.