This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those gifs 🙌 Would it make sense to also remove |
Good call! Also looks like |
Also found these style errors after running
|
There are conflicts in this merge request. Please solve it 👍 |
@anonrig ah, sorry. Fixed! |
Security comes first. Can you update ws and before updating read the changelog and notify us if anything is broken? Thank you. |
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that some of the
botkit
headers weren't aligned, so I fixed that.I also added shield.io badges for the most relevant information (npm version, dependency currentness
The
ws
vulnerability is described here and should be patched, but I'll leave that to y'all.