Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting & Typo fixes #128

Merged
merged 9 commits into from Feb 24, 2016
Merged

Formatting & Typo fixes #128

merged 9 commits into from Feb 24, 2016

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Feb 19, 2016

Noticed that some of the botkit headers weren't aligned, so I fixed that.

I also added shield.io badges for the most relevant information (npm version, dependency currentness

The ws vulnerability is described here and should be patched, but I'll leave that to y'all.

@chrisbodhi
Copy link

chrisbodhi commented Feb 21, 2016

Those gifs 🙌

Would it make sense to also remove tap-spec and tape from the package.json in this PR? It looks like they're leftover from how the tests used to run, and not being used anymore.

@xavdid
Copy link
Contributor Author

xavdid commented Feb 21, 2016

Good call! Also looks like node-env-file isn't being used either? The only place it shows up in the repo is in package.json itself. I'll pull all three.

@xavdid
Copy link
Contributor Author

xavdid commented Feb 21, 2016

Also found these style errors after running npm test, fixed.

Invalid quote mark found at ./lib/CoreBot.js :
   358 |
   359 |                            if (message.text || message.attachments) {
   360 |                                message.text = message.text && this.replaceTokens(message.text) || "";
-----------------------------------------------------------------------------------------------------------^
   361 |                                if (this.messages.length && !message.handler) {
   362 |                                    message.continue_typing = true;

Operator != should not stick to preceding expression at ./lib/Slack_web_api.js :
    86 |            },
    87 |            postMessage: function(options, cb) {
    88 |                if (options.attachments && typeof(options.attachments)!='string') {
------------------------------------------------------------------------------^
    89 |                    options.attachments = JSON.stringify(options.attachments);
    90 |                }

Operator != should not stick to following expression at ./lib/Slack_web_api.js :
    86 |            },
    87 |            postMessage: function(options, cb) {
    88 |                if (options.attachments && typeof(options.attachments)!='string') {
--------------------------------------------------------------------------------^
    89 |                    options.attachments = JSON.stringify(options.attachments);
    90 |                }

@anonrig
Copy link
Contributor

anonrig commented Feb 23, 2016

There are conflicts in this merge request. Please solve it 👍

@xavdid
Copy link
Contributor Author

xavdid commented Feb 23, 2016

@anonrig ah, sorry. Fixed!

@anonrig
Copy link
Contributor

anonrig commented Feb 23, 2016

Security comes first. Can you update ws and before updating read the changelog and notify us if anything is broken?

Thank you.

@xavdid
Copy link
Contributor Author

xavdid commented Feb 23, 2016

@anonrig the commit was a small one and after updating, all the tests and some tire-kicking passed.

@anonrig
Copy link
Contributor

anonrig commented Feb 24, 2016

Thank you!

anonrig added a commit that referenced this issue Feb 24, 2016
@anonrig anonrig merged commit febbd17 into howdyai:master Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants