Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cards typography #72

Merged
merged 4 commits into from Jul 1, 2019

Conversation

Projects
None yet
4 participants
@mg901
Copy link
Member

commented Jun 27, 2019

No description provided.

@sergeysova sergeysova requested review from sergeysova, meowsun and stuneak Jun 27, 2019


export const H1 = styled.h1`
margin: ${(p) => (p.narrow ? 0 : 3)}rem 0;
/* margin: ${(p) => (p.narrow ? 0 : 3)}rem 0; */

This comment has been minimized.

Copy link
@artalar

artalar Jun 27, 2019

Why commented out?

import { Routes } from "./routes"
import { GlobalStyles } from "./global-styles"

export const config = {
base: "14px",

This comment has been minimized.

Copy link
@artalar

artalar Jun 27, 2019

Why is not rems?

This comment has been minimized.

Copy link
@sergeysova

sergeysova Jun 28, 2019

Member

Typographist requires base in pixels. Because pixels is absolute independent unit

</GridCard>
</CardBox>
</CardNarrow>
<Rhythm>

This comment has been minimized.

Copy link
@sergeysova

sergeysova Jun 28, 2019

Member

Forget to remove rhythm?

@@ -1,7 +1,7 @@
import React from "react"
import PropTypes from "prop-types"
import styled from "styled-components"
import { above } from "styled-breakpoints"
import { up } from "@typographist/styled"

This comment has been minimized.

Copy link
@sergeysova

sergeysova Jun 28, 2019

Member

Maybe remove styled-breakpoints from dependencies?

user-select: none;
`

H4.propTypes = {

This comment has been minimized.

Copy link
@stuneak

stuneak Jun 28, 2019

Contributor

Wouldn't it be better to use flow instead of proptypes?

@sergeysova sergeysova merged commit 73c54fd into dev Jul 1, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@sergeysova sergeysova deleted the feat/cards-typography branch Jul 1, 2019

@sergeysova

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

@all-contributors please add @mg901 for design, code

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

@sergeysova

I've put up a pull request to add @mg901! 🎉

@sergeysova

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

@all-contributors please add @artalar for review

@allcontributors

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

@sergeysova

I've put up a pull request to add @artalar! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.