Fix no cards loading #73
Conversation
just to abstract over skeleton cards and loading state
|
Looks elegant |
| list={cards} | ||
| renderExists={(list) => ( | ||
| <CardsItemsBlock> | ||
| {list.filter(Boolean).map((card) => |
There was a problem hiding this comment.
list.map(card => Boolean(card) && render...
There was a problem hiding this comment.
In this case you will have array with empty elements
There was a problem hiding this comment.
Array of false and needed elements, so what?
There was a problem hiding this comment.
I think this is eager optimization
| export const SkeletonList = ({ | ||
| isLoading, | ||
| ids, | ||
| count = 3, |
There was a problem hiding this comment.
magic numbers. Need to move to named const
| <CardsList | ||
| key={`card-view-${current.id}`} | ||
| ids={[current.id]} | ||
| renderCard={({ card, onUsefulClick }) => ( |
There was a problem hiding this comment.
That function can be static (defined in the upper scope)
| }} | ||
| > | ||
| Favorite | ||
| <ZeroTab active={tab === "created"} onClick={() => setTab("created")}> |
There was a problem hiding this comment.
All string literals ("useful", "created") must be defined statically in one place and reused by imports for safety feature changes
There was a problem hiding this comment.
This is not a final solution. After a redesign, I will return to this code
Closes #69
Closes #68