New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license file does not accurately reflect licensing of sortable.js #13

Closed
xsgordon opened this Issue Feb 23, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@xsgordon
Contributor

xsgordon commented Feb 23, 2013

The doc/license file states that the licensing of the project is as follows:

License is GPLv2/GPLv3, see doc/GPLv2 and doc/GPLv3 respectively.

The header of the sortable.js file has this statement:

Table sorting script  by Joost de Valk, check it out at http://www.joostdevalk.nl/code/sortable-table/.
Based on a script from http://www.kryogenix.org/code/browser/sorttable/.
Distributed under the MIT license: http://www.kryogenix.org/code/browser/licence.html .

Copyright (c) 1997-2007 Stuart Langridge, Joost de Valk.

The license file should be updated to more accurately reflect the licensing for the project. For consistency the name of the file should also be LICENSE (all caps).

@hoxu

This comment has been minimized.

Show comment
Hide comment
@hoxu

hoxu Feb 24, 2013

Owner

Thanks for pointing out! If distro-specific packaging rules break because of the renaming, we'll know who to blame ;)

commit 3405250
Author: Heikki Hokkanen hoxu@users.sf.net
Date: Sun Feb 24 09:30:11 2013 +0200

Rename doc files to uppercase for consistency.

commit 0e059fc
Author: Heikki Hokkanen hoxu@users.sf.net
Date: Sun Feb 24 09:29:17 2013 +0200

Mention sortable.js license (MIT) in doc/license.

Thanks-to: Stephen Gordon <stephen.a.gordon@gmail.com>
Owner

hoxu commented Feb 24, 2013

Thanks for pointing out! If distro-specific packaging rules break because of the renaming, we'll know who to blame ;)

commit 3405250
Author: Heikki Hokkanen hoxu@users.sf.net
Date: Sun Feb 24 09:30:11 2013 +0200

Rename doc files to uppercase for consistency.

commit 0e059fc
Author: Heikki Hokkanen hoxu@users.sf.net
Date: Sun Feb 24 09:29:17 2013 +0200

Mention sortable.js license (MIT) in doc/license.

Thanks-to: Stephen Gordon <stephen.a.gordon@gmail.com>

@hoxu hoxu closed this Feb 24, 2013

@ghost ghost assigned hoxu Feb 24, 2013

@xsgordon

This comment has been minimized.

Show comment
Hide comment
@xsgordon

xsgordon Feb 24, 2013

Contributor

I actually noticed it while doing up the package review request for Fedora :):

https://bugzilla.redhat.com/show_bug.cgi?id=914996

Contributor

xsgordon commented Feb 24, 2013

I actually noticed it while doing up the package review request for Fedora :):

https://bugzilla.redhat.com/show_bug.cgi?id=914996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment