New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct splitting of git-ls-tree output #38

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dspinellis
Contributor

dspinellis commented Oct 23, 2014

Split limit 5 was off by one, which resulted in incorrect
processing of file paths with spaces embedded in them.
New split limit of 4 gets the required parts, because it
specifies the allowed number of splits, not elements:

mode type hash size name
1 2 3 4

Correct splitting of git-ls-tree output
Split limit 5 was off by one, which resulted in incorrect
processing of file paths with spaces embedded in them.
New split limit of 4 gets the required parts, because it
specifies the allowed number of splits, not elements:

mode type hash size name
    1    2    3    4
@hoxu

This comment has been minimized.

Owner

hoxu commented Nov 7, 2014

Nice catch - accepted & pushed out as eb812a4. Thanks!

@hoxu hoxu closed this Nov 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment