New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making it work on Ubutnu 16.04 on a repository with huge history #65

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Maxime2

Maxime2 commented May 21, 2016

  1. we do not need to use process wait as process communicate waits until process termination and the last process in the pipeline do not finish until all processes before it in the pipeline terminate, plus process wait may deadlock on pipes with huge output, see notice at https://docs.python.org/2/library/subprocess.html
  2. On Ubuntu 16.04 grep has started to give "Binary file (standard input) matches" notice into the pipe which breaks parsing.

This pull request fixes both issues making it working again on Ububtu 16.04 with our project.

Maxime2 added some commits May 21, 2016

process wait is not needed as process communicate waits until process…
… termination and the last process int the pipeline do not terminate until all previous processes int the pipeline terminate; in addition process wait may deadlock on big output
@anthrax-0

This comment has been minimized.

Show comment
Hide comment
@anthrax-0

anthrax-0 Oct 12, 2016

Is it possible to upvote PR? We have the same problem on older repositories and with non-ascii usernames

anthrax-0 commented Oct 12, 2016

Is it possible to upvote PR? We have the same problem on older repositories and with non-ascii usernames

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment