New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateDecoder no longer works #158

Closed
lechium opened this Issue Dec 19, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@lechium

lechium commented Dec 19, 2015

there is a new base.js file and the updateDecoder function in Youtube.js killer dies on this line specifically

var index = xhr2.responseText.indexOf(";var " + /^[$_A-Za-z0-9]+/.exec(match[1])[0] + "={"); with this error

[Error] TypeError: null is not an object (evaluating '/^[$_A-Za-z0-9]+/.exec(match[1])')
(anonymous function)

the new base.js file is here http://s.ytimg.com/yts/jsbin/player-en_US-vflXJM_5_/base.js

@hoyois

This comment has been minimized.

Show comment
Hide comment
@hoyois

hoyois Dec 19, 2015

Owner

Already fixed here: https://raw.githubusercontent.com/hoyois/plugin-to-html5/master/YouTube.js
BTW, this variant is immune to these changes: https://raw.githubusercontent.com/hoyois/plugin-to-html5/master/YouTubeXHR.js (although it has other disadvantages).

Owner

hoyois commented Dec 19, 2015

Already fixed here: https://raw.githubusercontent.com/hoyois/plugin-to-html5/master/YouTube.js
BTW, this variant is immune to these changes: https://raw.githubusercontent.com/hoyois/plugin-to-html5/master/YouTubeXHR.js (although it has other disadvantages).

@hoyois

This comment has been minimized.

Show comment
Hide comment
@hoyois

hoyois Dec 22, 2015

Owner

Fixed in v3.2.

Owner

hoyois commented Dec 22, 2015

Fixed in v3.2.

@hoyois hoyois closed this Dec 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment