New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings pragma #8

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@paultcochrane
Copy link
Contributor

paultcochrane commented Dec 19, 2017

This change adds the warnings pragma to all files which did not have it. Using the warnings pragma is considered current best practice, allows the code to almost pass Perl::Critic at severity level 4, and solves the use_warnings CPANTS issue.

This PR is submitted in the hope that it is useful. If you have any questions or comments, please don't hesitate to contact me and I can update and resubmit the PR as necessary.

@hoytech

This comment has been minimized.

Copy link
Owner

hoytech commented Dec 19, 2017

Normally I prefer common::sense over warnings, but in this case I believe I was trying to avoid a dependency. Sometimes warnings emits scary messages for perfectly legitimate code, and who knows what kind of warnings perl will add in the future, so I try to avoid it.

But this is a pretty simple module so it's probably OK, let's try it. Thanks!

@hoytech hoytech merged commit 1dfdd82 into hoytech:master Dec 19, 2017

@paultcochrane

This comment has been minimized.

Copy link
Contributor

paultcochrane commented Dec 19, 2017

Wow, thanks for the fast merges! I've got a few more PRs in the pipeline, so I hope they're of use to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment