New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial Travis-CI configuration #3

Merged
merged 1 commit into from Jan 9, 2018

Conversation

Projects
None yet
2 participants
@paultcochrane
Copy link
Contributor

paultcochrane commented Jan 9, 2018

Note that Perl 5.12 can't be tested since the installation of the
Alien::Electron dependency on this version hangs.

Hi there :-) I got another dist of yours for this month's PRC, hope you don't mind!

It seems there's an issue with Alien::Electron with Perl 5.12 that you might want to look into. After downloading the electron package, the process hangs and keeps burning CPU but does nothing. Anyway, thought you'd like to know about that.

BTW: I'm still mulling over the issue with the test failures in String::Compare::ConstantTime wrt utf8 etc. and have a couple of extra tests in the works, so will submit another pull request as soon as I get things more polished.

Paul Cochrane
Add initial Travis-CI configuration
Note that Perl 5.12 can't be tested since the installation of the
`Alien::Electron` dependency on this version hangs.

@hoytech hoytech referenced this pull request Jan 9, 2018

Open

Problem with perl 5.12 #3

@hoytech

This comment has been minimized.

Copy link
Owner

hoytech commented Jan 9, 2018

No don't mind at all! On the contrary it's much appreciated. Not sure what the problem with Alien::Electron is. That package is probably due for an upgrade soon for a newer version of electron. I've added an issue to remind me (or whoever) to look into it:

hoytech/Alien-Electron#3

The travis config for this looks good -- good idea to use xvfb. Thanks!

@hoytech hoytech merged commit d6eb882 into hoytech:master Jan 9, 2018

@hoytech

This comment has been minimized.

Copy link
Owner

hoytech commented Jan 9, 2018

Oh, and ya no worries about the utf8 stuff in String::Compare::ConstantTime, I'm still thinking what is best to do there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment