Don't check what's returned from passed function - #24
Merged
Conversation
Contributor
Author
|
Ok, I almost forgot to come back to this. I'll sort this over the weekend. |
Contributor
Author
|
Done, ready for merge. Travis is reporting a build error above as you can see. The tests passed with node 0.10 but on 0.9 it failed due to an npm glitch. Re-run the build or just merge as is, you can see the tests passing here. |
This was referenced Oct 19, 2014
Collaborator
|
+1 |
Collaborator
|
OK, I'll merge this PR since it's more suitable for the bahavior described in README. I regard this change as a bug fix. However, it's debatable whether using return value is more useful for the users or not. Thanks, @adam-lynch :) |
shinnn
added a commit
that referenced
this pull request
Mar 11, 2015
Don't check what's returned from passed function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, CoffeeScript will return the last line in a function. If you had the following:
Then your gulp task would fail with
TypeError: Arguments to path.join must be strings, unless you end the function withreturn path/return/returna falsy value.It's kinda ambiguous / confusing. I can't think of a use case where you'd edit the original but return something else (since the original will overridden with what you return anyway).
I didn't check the tests, I just made this change on github.com. If they fail, I'll come back to them later.