Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contact links and disable drawer #27

Merged
merged 3 commits into from
Nov 25, 2022
Merged

add contact links and disable drawer #27

merged 3 commits into from
Nov 25, 2022

Conversation

vsoch
Copy link
Collaborator

@vsoch vsoch commented Nov 24, 2022

@alansill I think I'd like your feedback on these changes before merging! Specifically:

  • I added the discussions link front and center (the main pages) and the Mastodon links (profile and about) on the Mastodon project page - I think that's where people will want to find them or go looking for them, and we can think about some more general "contact" page later.
  • I find the drawer kind of distracting? I think the user should come to the site and make a choice to click on something. And then it should not be possible to erroneously go back (this was a bug detected by @alecbcs) so I've disabled the drawer for now.
  • I'm fairly picky about external links opening to blank, so I've fixed this at least for our opening page. External links on the rest of the site either need to be explicitly defined, or some other tweak I haven't found yet.

Signed-off-by: vsoch vsoch@users.noreply.github.com

I find the drawer kind of distracting? I think the user
should come to the site and make a choice to click on something.
And then it should not be possible to erroneously go back.

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@alansill
Copy link
Contributor

Off to dinner, will check tomorrow.

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for hpc-social ready!

Name Link
🔨 Latest commit 055f8f6
🔍 Latest deploy log https://app.netlify.com/sites/hpc-social/deploys/6380073442eb3c00099ea64d
😎 Deploy Preview https://deploy-preview-27--hpc-social.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@alansill
Copy link
Contributor

I tried the Netlify previews but donʻt see a drawer functionality to test. What am I looking for?

@vsoch
Copy link
Collaborator Author

vsoch commented Nov 25, 2022

The drawer is disabled so you shouldn’t see anything :) it was the arrow on the first screen you could drag to the left to open. It was buggy in that if you want back the arrow would be gone.

@alansill
Copy link
Contributor

Iʻm not seeing an arrow in the Netlify preview on my iPad. The full-graphic image on the home page does slide to the left if you click any of the links but that was working before this PR as far as I remember. Nothing seems to slide it back closed so itʻs a bit non-intuitive that way but I donʻt see that as a problem.

It doesnʻt seem to break anything so I will go ahead and merge.

@alansill alansill merged commit a27a299 into main Nov 25, 2022
@alansill alansill deleted the add/contacts branch November 25, 2022 17:06
@vsoch
Copy link
Collaborator Author

vsoch commented Nov 25, 2022

Thanks! To be clear you shouldn’t see anything - the drawer is removed. It’s a bit simpler functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants