Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documented dependencies should mention ShellCheck #645

Closed
rstyd opened this issue Feb 14, 2020 · 1 comment
Closed

documented dependencies should mention ShellCheck #645

rstyd opened this issue Feb 14, 2020 · 1 comment
Assignees
@reidpr
Labels
bug
Milestone
0.17

Comments

@rstyd
Copy link
Contributor

rstyd commented Feb 14, 2020 •
edited

I noticed the Contributor's Guide doesn't mention ShellCheck. It should list ShellCheck as a development dependency and state which version we require. Installation instructions are located at https://github.com/koalaman/shellcheck/tree/v0.7.0#installing.
@rstyd rstyd added the bug label Feb 14, 2020
@reidpr reidpr changed the title Contributor's Guide in Docs Should Mention Shellcheck documented dependencies should mention ShellCheck Feb 21, 2020
@reidpr reidpr added this to the 0.15 milestone Feb 21, 2020
@reidpr
Copy link
Collaborator

reidpr commented Feb 21, 2020

This should go in configure, since it's needed to run the complete test suite, and also the installation instructions so we can provide a link. It's a bit hidden how to find the static binary.

@reidpr reidpr modified the milestones: 0.15, 0.16 Apr 3, 2020
@reidpr reidpr modified the milestones: 0.16, 0.17 May 15, 2020
@reidpr reidpr assigned reidpr and unassigned rstyd May 20, 2020
@reidpr reidpr mentioned this issue May 21, 2020
Merged
@reidpr reidpr closed this as completed in 8948960 Jun 22, 2020
j-ogas pushed a commit that referenced this issue Aug 14, 2020
@reidpr @j-ogas
PR #746 from me: document test suite dependency on ShellCheck (closes #…
cfaef9f 
…645)
j-ogas pushed a commit that referenced this issue Aug 25, 2020
@reidpr @j-ogas
PR #746 from me: document test suite dependency on ShellCheck (closes #…
0725afb 
…645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reidpr reidpr

Labels
bug
Projects
None yet
Milestone
0.17
Development

No branches or pull requests
2 participants
@rstyd @reidpr