Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
added DTCMP sorts and used them instead of original serial sorts #227
Nice work, @levatin1 ! It's not trivial to figure out DTCMP calls.
Let's iterate on this a bit more. We can reuse the comparison function you have, but let's change this to do two things:
It will still function with these two changes, and the benefit will be that we can start with the strings distributed across ranks.
This explanation is a bit handy-wavy, so I'm happy to discuss over the phone.
Hi @levatin1 , given the large amount of new code in this PR, I'm guessing we'll have to iterate several times before we have this running so don't get discouraged if it keeps crashing.
One issue I see here is that dnamlen is not assigned a value before we use it to create a new MPI datatype in these lines:
We'll need to move those lines down after the point where dnamlen is given a value.