New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding code to track if read error was on src or dest side #88

Merged
merged 8 commits into from Aug 28, 2017

Conversation

Projects
None yet
2 participants
@dsikich
Member

dsikich commented Aug 25, 2017

  • added code to dcmp_strmap_compare_data & dcmp_compare_data to track whether or not the open file/reading errors were on the src or dest side

@dsikich dsikich requested a review from adammoody Aug 25, 2017

@adammoody

This comment has been minimized.

Show comment
Hide comment
@adammoody

adammoody Aug 25, 2017

Member

Looking at this code again, let's move the MFU_LOG message about src/dest inside of the function. This way we can also report the type of operation that failed, e.g., open vs read vs lseek. We'll still return -1 from the function and print the second error message from the calling routine.

Member

adammoody commented Aug 25, 2017

Looking at this code again, let's move the MFU_LOG message about src/dest inside of the function. This way we can also report the type of operation that failed, e.g., open vs read vs lseek. We'll still return -1 from the function and print the second error message from the calling routine.

@dsikich dsikich merged commit 08d29e4 into master Aug 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dsikich dsikich deleted the dcmp-reporting branch Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment