Add support to HWP in beam convolution #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix the divergent history of #534 |
keskitalo
force-pushed
the
toast3_TEB_conv_merge
branch
from
e6914f8 to
e70f6f0
Compare
tskisner
requested changes
Apr 27, 2022
cmake.sh
Outdated
| @@ -0,0 +1 @@ | |||
| cmake .. -DCMAKE_INSTALL_PREFIX=$PREFIX | |||
There was a problem hiding this comment.
Was this script accidentally committed? If you have a specific set of cmake options needed for a system, feel free to add a script to the platforms directory. We could consider adding a default.sh script or similar.
There was a problem hiding this comment.
Oops! Removed the unnecessary file.
src/toast/ops/conviqt.py
Outdated
|
|
||
| theta, phi, psi, psi_pol = self.get_pointing(data, det, verbose) | ||
| np.savez(f'{self.det_data}_{det}.npz', psi=psi, psi_pol=psi_pol, | ||
| theta=theta, phi=phi) |
There was a problem hiding this comment.
Could we guard this debug dumping by a line like:
# (assuming that Environment was imported at the top of the file)
env = Environment.get()
if env.log_level == "VERBOSE":
np.savez(...)
or use some other internal verbose settting in the class.
There was a problem hiding this comment.
That is a leftover debugging statement. Now removed.
| print("libconviqt not available, skipping tests") | ||
| return | ||
|
|
||
| # Create a fake scan strategy that hits every pixel once. |
| ): | ||
| fail = True | ||
| # Create a fake scan strategy that hits every pixel once. | ||
| # data = create_healpix_ring_satellite(self.comm, nside=self.nside) |
There was a problem hiding this comment.
You can remove this, and the comment
|
Addressed review comments and will merge once the unit tests finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.