Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tensor] add module check and bert test #1031

Merged
merged 9 commits into from
May 26, 2022
Merged

[Tensor] add module check and bert test #1031

merged 9 commits into from
May 26, 2022

Conversation

Wesley-Jzy
Copy link
Contributor

@Wesley-Jzy Wesley-Jzy commented May 26, 2022 •
edited
Loading

  1. Add ColoEmbedding
  2. Add test on Bert
  3. Add check shared param in different layer
  4. Add check_module unit test

@feifeibear
Copy link
Contributor

Did you have a unitest for Feature 3?
Add check duplicated param in different layer

@Wesley-Jzy
Copy link
Contributor Author

Did you have a unitest for Feature 3? Add check duplicated param in different layer

run_check_duplicated_param is working for this.

feifeibear
feifeibear reviewed May 26, 2022
View reviewed changes
colossalai/tensor/colo_parameter.py Outdated Show resolved Hide resolved
colossalai/tensor/colo_parameter.py Outdated Show resolved Hide resolved
colossalai/tensor/module_utils.py Show resolved Hide resolved
colossalai/tensor/module_utils.py Outdated Show resolved Hide resolved
@Wesley-Jzy Wesley-Jzy merged commit 6c5996a into hpcaitech:main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feifeibear feifeibear feifeibear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wesley-Jzy @feifeibear