Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-17790 WsESDLConfig ensures method name uniqueness #10185

Conversation

rpastrana
Copy link
Member

@rpastrana rpastrana commented Jun 29, 2017

  • Rejects binding requests containing method duplicates

Signed-off-by: Rodrigo Pastrana rodrigo.pastrana@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browers
    • The component(s) render as expected

Testing:

- Rejects binding requests containing method duplicates

Signed-off-by: Rodrigo Pastrana <rodrigo.pastrana@lexisnexis.com>
@hpcc-jirabot
Copy link

@rpastrana rpastrana changed the base branch from master to candidate-6.4.0 June 29, 2017 21:13
@rpastrana
Copy link
Member Author

@wangkx please review.

Copy link
Member

@wangkx wangkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpastrana looks fine.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
Sha: e29e596
Build: success
Build: success
ECL Watch: Rebuilding Site

errors warnings build time
0 65 93.332 seconds

Install hpccsystems-platform-community_6.4.0-rc5.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 94 94 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 733 733 0
test (thor) 627 627 0
test (roxie) 760 760 0

HPCC Stop: OK
HPCC Uninstall: OK

@richardkchapman
Copy link
Member

Jira says 7.0.0 but this is targetting 6.4.0 - which is right?

@rpastrana
Copy link
Member Author

rpastrana commented Jun 30, 2017

It should be targeting 6.4.0. It addresses a minor issue exposed by new UI code in 6.4.

@richardkchapman richardkchapman merged commit 596cd2d into hpcc-systems:candidate-6.4.0 Jun 30, 2017
@rpastrana
Copy link
Member Author

FYI @miguelvazq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants