Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-18209 Avoid losing casts which change signedness from sort orders #10389

Merged
merged 1 commit into from Sep 18, 2017

Conversation

@ghalliday
Copy link
Member

commented Sep 1, 2017

This might possibly have caused an incorrect sort order (e.g. a negative
value cast as unsigned). It could also create an internal inconsistency
which caused a stack fault by repeatedly applying a transformation.

Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

This might possibly have caused an incorrect sort order (e.g. a negative
value cast as unsigned).  It could also create an internal inconsistency
which caused a stack fault by repeatedly applying a transformation.

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@hpcc-jirabot

This comment has been minimized.

Copy link

commented Sep 1, 2017

@ghalliday

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2017

@richardkchapman for consideration in 6.4.2. It does potentially change the results of a query (see attached example), so not sure if it should go in 6.4.4 - or left to 7.0

@shamser please review.

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2017

Automated Smoketest:
Sha: d9fad27
Build: success
Build: success
ECL Watch: Rebuilding Site

errors warnings build time
0 65 92.679 seconds

Install hpccsystems-platform-community_6.4.2-rc2.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 96 96 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 733 733 0
test (thor) 627 627 0
test (roxie) 760 760 0

HPCC Stop: OK
HPCC Uninstall: OK

@shamser
shamser approved these changes Sep 4, 2017
Copy link
Contributor

left a comment

@richardkchapman Code reviewed. Looks good.

@richardkchapman richardkchapman merged commit cfdc62e into hpcc-systems:candidate-6.4.2 Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.