Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-18128 Allow default parameter values for dictionaries (and other types) #10468

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
5 participants
@ghalliday
Copy link
Member

commented Sep 28, 2017

Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

HPCC-18128 Allow default parameter values for dictionaries (and other…
… types)

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@hpcc-jirabot

This comment has been minimized.

Copy link

commented Sep 28, 2017

@ghalliday

This comment has been minimized.

Copy link
Member Author

commented Sep 28, 2017

@shamser please review. I have fixed by allowing any value after the assignments - which includes dictionaries. It should have no problems with backward compatibility, so suitable for point release.

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2017

Automated Smoketest:
Sha: a206fe3
Build: success
Build: success
ECL Watch: Rebuilding Site

errors warnings build time
0 65 91.959 seconds

Install hpccsystems-platform-community_6.4.3-closedown0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 96 96 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 733 733 0
test (thor) 627 627 0
test (roxie) 760 760 0

HPCC Stop: OK
HPCC Uninstall: OK

@shamser
Copy link
Contributor

left a comment

@richardkchapman Code reviewed. Looks good.

@richardkchapman

This comment has been minimized.

Copy link
Member

commented Oct 17, 2017

@ghalliday Slight concern about whether 6.4.4 (as opposed to 7.0) is an appropriate target for this fix

@ghalliday ghalliday changed the base branch from candidate-6.4.4 to master Oct 18, 2017

@ghalliday

This comment has been minimized.

Copy link
Member Author

commented Oct 18, 2017

@richardkchapman moved to 7.0.0

@richardkchapman richardkchapman merged commit 8d0db5b into hpcc-systems:master Oct 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.