Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-18574 Use --nostdinc when compiling with eclccserver #10537

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
4 participants
@ghalliday
Copy link
Member

commented Oct 20, 2017

Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

HPCC-18574 Use --nostdinc when compiling with eclccserver
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@hpcc-jirabot

This comment has been minimized.

Copy link

commented Oct 20, 2017

@ghalliday

This comment has been minimized.

Copy link
Member Author

commented Oct 20, 2017

@richardkchapman please consider for 6.4.4. I have managed to provide a workaround (setting option eclcc--nostdinc-1=1, but it is a bit ugly)

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented Oct 20, 2017

Automated Smoketest:
Sha: 53ff08b
Build: success
Build: success
ECL Watch: Rebuilding Site

errors warnings build time
0 65 92.408 seconds

Install hpccsystems-platform-community_6.4.4-rc1.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 96 96 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 733 733 0
test (thor) 627 627 0
test (roxie) 760 760 0

HPCC Stop: OK
HPCC Uninstall: OK

@@ -331,6 +331,7 @@ class EclccCompileThread : implements IPooledThread, implements IErrorReporter,
if (mainDefinition.length())
eclccCmd.append(" -main ").append(mainDefinition);
eclccCmd.append(" --timings");
eclccCmd.append(" --nostdinc");

This comment has been minimized.

Copy link
@richardkchapman

richardkchapman Oct 23, 2017

Member

If there ever was a situation where stdinc WAS needed, would they be able to override this?

This comment has been minimized.

Copy link
@ghalliday

ghalliday Oct 25, 2017

Author Member

They could by setting --eclcc--nostdinc-1 to 0

@richardkchapman richardkchapman merged commit 178e64c into hpcc-systems:candidate-6.4.4 Oct 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.