Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-18841 Embedded python may lock up at process termination #10707

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
4 participants
@richardkchapman
Copy link
Member

richardkchapman commented Dec 5, 2017

This can cause issues for eclagent processes in particular

Signed-off-by: Richard Chapman rchapman@hpccsystems.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

Used the test code supplied in the Jira. This is not suitable for addition to the regression suite due to multiple external dependencies and long execution time.

HPCC-18841 Embedded python may lock up at process termination
This can cause issues for eclagent processes in particular

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
@hpcc-jirabot

This comment has been minimized.

Copy link

hpcc-jirabot commented Dec 5, 2017

@richardkchapman

This comment has been minimized.

Copy link
Member Author

richardkchapman commented Dec 5, 2017

@ghalliday Please review

Note that I have targeted 6.4.6 for now but unless there is another RC it should be pushed to 6.4.8

@ghalliday

This comment has been minimized.

Copy link
Member

ghalliday commented Dec 5, 2017

@richardkchapman does this need an equivalent change in py3embed?

@richardkchapman richardkchapman force-pushed the richardkchapman:python-tsr branch from 51abdc5 to b33bca5 Dec 6, 2017

@richardkchapman

This comment has been minimized.

Copy link
Member Author

richardkchapman commented Dec 6, 2017

@ghalliday Yes - I had made one but it needed a force-push. Repushed

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

HPCCSmoketest commented Dec 6, 2017

Automated Smoketest:
Sha: b33bca5
Build: success
Install hpccsystems-platform-community_6.4.6-rc4.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 97 97 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 734 734 0
test (thor) 628 628 0
test (roxie) 761 761 0

HPCC Stop: OK
HPCC Uninstall: OK

@ghalliday

This comment has been minimized.

Copy link
Member

ghalliday commented Dec 6, 2017

Looks ready to merge. Will merge once the target version is decided.

@richardkchapman richardkchapman changed the base branch from candidate-6.4.6 to candidate-6.4.8 Dec 6, 2017

@ghalliday ghalliday merged commit 764e7c2 into hpcc-systems:candidate-6.4.8 Dec 6, 2017

@richardkchapman richardkchapman deleted the richardkchapman:python-tsr branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.