New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-18391 Copy env xml and conf files only if they don't exist #10813
HPCC-18391 Copy env xml and conf files only if they don't exist #10813
Conversation
https://track.hpccsystems.com/browse/HPCC-18391 |
@mayx Please review |
@Michael-Gardner Your change does the check during generation of the install make files. I think it should be checked inside the install make files. The situation could well change between make file generation and install. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the check should be done at install time, instead of make file generation time.
Signed-off-by: Michael Gardner <michael.gardner@lexisnexisrisk.com>
9cb5bc2
to
9de9ed6
Compare
Signed-off-by: Michael Gardner <michael.gardner@lexisnexisrisk.com>
9de9ed6
to
be538a3
Compare
@mayx I've changed it to be done at installation time. |
Automated Smoketest: ✅ Unit tests result:
Regression test result:
HPCC Stop: OK
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Michael-Gardner looks good.
Signed-off-by: Michael Gardner michael.gardner@lexisnexisrisk.com
Type of change:
Checklist:
Testing: