Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-18524 DOCS:Improve Physical Files description #10822

Merged

Conversation

g-pan
Copy link
Member

@g-pan g-pan commented Jan 26, 2018

Fix HPCC-18524 DOCS:Improve Physical Files description
In the Installing and Running document where we detail File scopes
and permissions, we need to improve the description of the Phyiscal Files
menu item as found in ECL Watch.

Signed-off-by: G-Pan greg.panagiotatos@lexisnexis.com

@JamesDeFabia please review
@RussWhitehead please review

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately

Testing:

Successful Build test and resulting PDF files: http://10.240.32.243/view/Docs/job/DocDev05/

Fix HPCC-18524 DOCS:Improve Physical Files description
In the Installing and Running document where we detail File scopes
and permissions, we need to improve the description of the Phyiscal Files
menu item as found in ECL Watch.

Signed-off-by: G-Pan <greg.panagiotatos@lexisnexis.com>
@hpcc-jirabot
Copy link

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
Sha: 8c16916
Build: success
Install hpccsystems-platform-community_6.4.1-documentation0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 95 95 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 733 733 0
test (thor) 627 627 0
test (roxie) 760 760 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
19 sec (00:00:19) 345 sec (00:05:45) 89 sec (00:01:29) 5 sec (00:00:05) 33 sec (00:00:33) 1092 sec (00:18:12) 32 sec (00:00:32) 1615 sec (00:26:55)

Copy link
Contributor

@JamesDeFabia JamesDeFabia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from my POV. @RussWhitehead should have the last word

@RussWhitehead
Copy link
Member

Looks good to me

@richardkchapman richardkchapman merged commit c58766f into hpcc-systems:candidate-6.4.x Jan 30, 2018
@g-pan g-pan deleted the H18524-PhysFiles branch January 30, 2018 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants