Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-19429 Add version number for DESDL requests #11026

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
6 participants
@miguelvazq
Copy link
Member

commented Apr 13, 2018

Add version number to keep backwards compatibility for the DESDL U/I.

Signed-off by: Miguel Vazquez miguel.vazquez@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

@hpcc-jirabot

This comment has been minimized.

Copy link

commented Apr 13, 2018

@miguelvazq

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2018

@mayx Please comment / review.

@miguelvazq

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2018

@GordonSmith Please review.

@mayx

This comment has been minimized.

Copy link
Member

commented Apr 13, 2018

Don't think we need to show the ver_ on the binding summary page.

@@ -160,7 +161,8 @@ define([
Port: TpBinding.Port,
DefinitionID: TpBinding.ESDLBinding.Definition.Id,
Service: TpBinding.ESDLBinding.Definition.Name,
Protocol: TpBinding.Protocol
Protocol: TpBinding.Protocol,
ver_: "1.3"

This comment has been minimized.

Copy link
@mayx

mayx Apr 13, 2018

Member

Don't think we need to show the ver_ on the binding summary page.

HPCC-19429 Add version number for DESDL requests
Add version number to keep backwards compatibility for the DESDL U/I.

Signed-off by: Miguel Vazquez <miguel.vazquez@lexisnexis.com>

@miguelvazq miguelvazq force-pushed the miguelvazq:HPCC-19429 branch from 5b661a4 to a81c26e Apr 13, 2018

@miguelvazq

This comment has been minimized.

Copy link
Member Author

commented Apr 13, 2018

@mayx Updated.

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2018

Automated Smoketest:
OS: centos 7.2.1511 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: a81c26e
Build: success
ECL Watch: Rebuilding Site
Rebuild: success
Install hpccsystems-platform-community_6.5.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 85 85 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 759 759 0
test (thor) 686 686 0
test (roxie) 799 799 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
22 sec (00:00:22) 183 sec (00:03:03) 114 sec (00:01:54) 6 sec (00:00:06) 22 sec (00:00:22) 1099 sec (00:18:19) 16 sec (00:00:16) 1462 sec (00:24:22)

@richardkchapman richardkchapman merged commit 3bf74ad into hpcc-systems:master Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.