Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-19463 Allow system to build on windows #11056

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
4 participants
@ghalliday
Copy link
Member

commented Apr 20, 2018

Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

HPCC-19463 Allow system to build on windows
Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@ghalliday

This comment has been minimized.

Copy link
Member Author

commented Apr 20, 2018

@RussWhitehead what do you think of this fix? (With a dummy implemention if no openssl.) Feel free to comment/reject/replace/laugh.

@RussWhitehead

This comment has been minimized.

Copy link
Member

commented Apr 20, 2018

@ghalliday That looks similar to what I gave Ming yesterday to build with. I do like yours better with the dummy implementation

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2018

Automated Smoketest:
OS: centos 7.2.1511 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: f515a4f
Build: success
Install hpccsystems-platform-community_6.5.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 88 88 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 776 776 0
test (thor) 707 707 0
test (roxie) 820 820 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
12 sec (00:00:12) 184 sec (00:03:04) 55 sec (00:00:55) 6 sec (00:00:06) 21 sec (00:00:21) 1162 sec (00:19:22) 17 sec (00:00:17) 1457 sec (00:24:17)
@RussWhitehead
Copy link
Member

left a comment

Looks good as is

@ghalliday

This comment has been minimized.

Copy link
Member Author

commented Apr 23, 2018

@richardkchapman please review

@richardkchapman richardkchapman merged commit e444d6d into hpcc-systems:master Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.