Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-15684 DOCS:ESPArray needs max_count or max_count_var #11139

Merged
merged 2 commits into from May 14, 2018

Conversation

Projects
None yet
5 participants
@JamesDeFabia
Copy link
Contributor

commented May 8, 2018

Signed-off-by: Jim DeFabia jamesdefabia@lexisnexis.com
@afishbeck Please review

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

Jim DeFabia
HPCC-15684 DOCS:ESPArray needs max_count or max_count_var
Signed-off-by: Jim DeFabia <jamesdefabia@lexisnexis.com>
@hpcc-jirabot

This comment has been minimized.

Copy link

commented May 8, 2018

@afishbeck
Copy link
Member

left a comment

@JamesDeFabia Just two comments in areas that didn't actually change.

max items in a dataset (ESParray).</para>
</indexterm>The max_count_var attribute is used to specify a variable (an
ECL Attribute) cotaining the value of the expected max items in a dataset
(ESParray).</para>

<para><emphasis role="bold">Example:</emphasis></para>

<programlisting>[max_count_var("iesp.Constants.JD.MaxRecords")] ESParray &lt;ESPstruct MYRecord, Record&gt; Records; </programlisting>

<para>Roxie will define the constant iesp.Constants.JD.MaxRecords and change

This comment has been minimized.

Copy link
@afishbeck

afishbeck May 10, 2018

Member

Rather than "Roxie will", perhaps the "ECL developer must"?

max items in a dataset (ESParray).</para>
</indexterm>The max_count_var attribute is used to specify a variable (an
ECL Attribute) cotaining the value of the expected max items in a dataset
(ESParray).</para>

<para><emphasis role="bold">Example:</emphasis></para>

<programlisting>[max_count_var("iesp.Constants.JD.MaxRecords")] ESParray &lt;ESPstruct MYRecord, Record&gt; Records; </programlisting>

<para>Roxie will define the constant iesp.Constants.JD.MaxRecords and change
it at will without affecting ESP.</para>

This comment has been minimized.

Copy link
@afishbeck

afishbeck May 10, 2018

Member

and if you change above, then instead of "without affecting ESP", use "rather than hard coding the value in the ESDL"?

Jim DeFabia
HPCC-15684 DOCS:ESPArray needs max_count or max_count_var
Signed-off-by: Jim DeFabia <jamesdefabia@lexisnexis.com>
@JamesDeFabia

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2018

@afishbeck requested changes made, back to you

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented May 11, 2018

Automated Smoketest:
OS: centos 7.2.1511 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: ecde351
Build: success
Install hpccsystems-platform-community_6.5.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 88 88 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 784 784 0
test (thor) 715 715 0
test (roxie) 828 828 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
10 sec (00:00:10) 319 sec (00:05:19) 108 sec (00:01:48) 6 sec (00:00:06) 27 sec (00:00:27) 1210 sec (00:20:10) 19 sec (00:00:19) 1699 sec (00:28:19)
@afishbeck
Copy link
Member

left a comment

@JamesDeFabia looks good.

@richardkchapman richardkchapman merged commit 388516a into hpcc-systems:master May 14, 2018

@JamesDeFabia JamesDeFabia deleted the JamesDeFabia:HPCC-15684MaxCount branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.