Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-19267 Add a flushDiskCache option option switchable by //version in to regression suite #11143

Merged

Conversation

Projects
None yet
4 participants
@AttilaVamos
Copy link
Contributor

commented May 10, 2018

Implement flushDiskCache in versioning.
Add --flushDiskCache as a command line parameter
Handle flushDiskcache on ecl execution level
Add user privilege check
Extend error handling and error messages

Update README.rst

Signed-off-by: Attila Vamos attila.vamos@gmail.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

Tested manually on a local VM with and without sudo privileges.

@hpcc-jirabot

This comment has been minimized.

Copy link

commented May 10, 2018

@AttilaVamos

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2018

@richardkchapman please review

@@ -115,7 +115,7 @@ def emit(self, record):
msg = self.format(record)
stream = self.stream
isBuffer = hasattr(record, 'filebuffer')
toSort = hasattr(record, 'filesort')
#toSort = hasattr(record, 'filesort')

This comment has been minimized.

Copy link
@richardkchapman

richardkchapman May 10, 2018

Member

Why is this commented out?

This comment has been minimized.

Copy link
@AttilaVamos

AttilaVamos May 10, 2018

Author Contributor

That was an unused variable, removed.
(Long time ago there was a forced sort for log lines when parallel queries used. It is already improved, the sort replaced by speed effective data structure, but somehow this line left there. Now the Python IDE put a notification to that line, I commented out before test and forget to remove before push.)

@@ -498,6 +502,13 @@ def setElapsTime(self, time):
self.elapsTime = time

def setJobnameVersion(self, version):
# Overrides the global flushDiskCache parameter if --pq <= 1
# There is no sense to clear disk cache if same test runnnig parallel by versioning

This comment has been minimized.

Copy link
@richardkchapman

richardkchapman May 10, 2018

Member

typo - runnnig

This comment has been minimized.

Copy link
@AttilaVamos

AttilaVamos May 10, 2018

Author Contributor

Changed

@richardkchapman

This comment has been minimized.

Copy link
Member

commented May 10, 2018

@AttilaVamos A couple of minor questions

HPCC-19267 Add a flushDiskCache option option switchable by //version…
… in to regression suite

Implement flushDiskCache in versioning.
Add --flushDiskCache as a command line parameter
Handle flushDiskcache on ecl execution level
Add user privilege check
Extend error handling and error messages

Update README.rst

Tested manually.

Signed-off-by: Attila Vamos <attila.vamos@gmail.com>

@AttilaVamos AttilaVamos force-pushed the AttilaVamos:HPCC-19267-improvement-7.0.0 branch from 1f8dd0a to 6d05452 May 10, 2018

@AttilaVamos

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2018

@richardkchapman updated, please check and merge.

@richardkchapman richardkchapman merged commit 1e680c0 into hpcc-systems:master May 10, 2018

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented May 10, 2018

Automated Smoketest:
OS: centos 7.2.1511 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 6d05452
Number of Error(s): 7
collect2: error: ld returned 1 exit status

Build error:
Build log Build log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.