Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-19826 Correct the scope in Thor for stats on activities in child queries #11268

merged 1 commit into from Jun 6, 2018


None yet
5 participants
Copy link

ghalliday commented Jun 1, 2018

Signed-off-by: Gavin Halliday

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)


  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected


HPCC-19826 Correct the scope in Thor for stats on activities in child…
… queries

Signed-off-by: Gavin Halliday <>

This comment has been minimized.

Copy link

hpcc-jirabot commented Jun 1, 2018
Jira not updated (user does not match)


This comment has been minimized.

Copy link
Member Author

ghalliday commented Jun 1, 2018

@jakesmith please review

@ghalliday ghalliday closed this Jun 1, 2018

@ghalliday ghalliday reopened this Jun 1, 2018


This comment has been minimized.

Copy link

hpcc-jirabot commented Jun 1, 2018


This comment has been minimized.

Copy link

HPCCSmoketest commented Jun 1, 2018

Automated Smoketest:
OS: centos 7.2.1511 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: b1579e9
Build: success
Install hpccsystems-platform-community_7.0.0-beta1rc2.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 88 88 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 786 786 0
test (thor) 717 717 0
test (roxie) 830 830 0

HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
10 sec (00:00:10) 174 sec (00:02:54) 60 sec (00:01:00) 9 sec (00:00:09) 30 sec (00:00:30) 1380 sec (00:23:00) 18 sec (00:00:18) 1681 sec (00:28:01)

This comment has been minimized.

Copy link

jakesmith commented Jun 5, 2018

Looks good.
I cherry-picked your change and tested it with the query I spotted the issues in and the stats look much better now.

@ghalliday - ready to merge.

@richardkchapman richardkchapman changed the base branch from candidate-7.0.0beta1 to master Jun 6, 2018

@richardkchapman richardkchapman merged commit 6b01f39 into hpcc-systems:master Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.