Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-20215 ECLWatch script error when using optional "/esp/files/stub… #11529

Merged

Conversation

Projects
None yet
4 participants
@GordonSmith
Copy link
Member

commented Aug 2, 2018

….htm"

Change call to "esp/getauthtype" to be absolute.

Fixes HPCC-20215

Signed-off-by: Gordon Smith gordonjsmith@gmail.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

HPCC-20215 ECLWatch script error
Issue when urls contain the "/esp/files/stub.htm" address prefix.
Change call to "esp/getauthtype" to be absolute.
XMLHttpRequest callback should be set before calling send.
Added extra check for valid response.

Fixes HPCC-20215

Signed-off-by: Gordon Smith <gordonjsmith@gmail.com>

@GordonSmith GordonSmith force-pushed the GordonSmith:HPCC-20215-IDEScriptIssue branch from 40aec5c to 3790594 Aug 2, 2018

@GordonSmith

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2018

@miguelvazq please review

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2018

Automated Smoketest:
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 3790594
Build: success
ECL Watch: Rebuilding Site
Rebuild: success
Install hpccsystems-platform-community_7.0.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 89 89 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 804 804 0
test (thor) 729 729 0
test (roxie) 878 878 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
23 sec (00:00:23) 171 sec (00:02:51) 125 sec (00:02:05) 8 sec (00:00:08) 29 sec (00:00:29) 1337 sec (00:22:17) 17 sec (00:00:17) 1710 sec (00:28:30)
@miguelvazq
Copy link
Member

left a comment

One question

var responseType = (this.responseXML.childNodes[0].textContent);
if (this.readyState == 4 && this.status == 200 && this.responseXML.childNodes[0].textContent == responseType){
xhttp.onload = function () {
var responseType = this.responseXML && this.responseXML.childNodes && this.responseXML.childNodes.length ? this.responseXML.childNodes[0].textContent : "None";

This comment has been minimized.

Copy link
@miguelvazq

miguelvazq Aug 2, 2018

Member

@GordonSmith should this have a case for "None" now? FYI @kunalaswani

This comment has been minimized.

Copy link
@miguelvazq

miguelvazq Aug 7, 2018

Member

If default is going to give the same results as none. Then this is good.

var responseType = (this.responseXML.childNodes[0].textContent);
if (this.readyState == 4 && this.status == 200 && this.responseXML.childNodes[0].textContent == responseType){
xhttp.onload = function () {
var responseType = this.responseXML && this.responseXML.childNodes && this.responseXML.childNodes.length ? this.responseXML.childNodes[0].textContent : "None";

This comment has been minimized.

Copy link
@miguelvazq

miguelvazq Aug 7, 2018

Member

If default is going to give the same results as none. Then this is good.

@ghalliday ghalliday merged commit f70db3e into hpcc-systems:master Aug 8, 2018

@GordonSmith GordonSmith deleted the GordonSmith:HPCC-20215-IDEScriptIssue branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.