Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-20200 Improve attribute group processing #11532

Merged
merged 1 commit into from Aug 6, 2018

Conversation

Projects
None yet
5 participants
@kenrowland
Copy link
Contributor

commented Aug 2, 2018

Improve attribute group processing

Signed-off-by: Ken Rowland kenneth.rowland@lexisnexisrisk.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

@hpcc-jirabot

This comment has been minimized.

Copy link

commented Aug 2, 2018

@kenrowland

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2018

@rpastrana Please review.

Only look at the last commit. The previous are cherry picked dependencies from PRs that had not been rebased and merged. I will of course rebase prior to merging. Also note that it is possible that a late review change from PRs whose commits I cherry picked may not be present, but will be picked up when those PRs are merged and I rebase.

@rpastrana
Copy link
Member

left a comment

@kenrowland
Did not review XSDs

@richardkchapman

This comment has been minimized.

Copy link
Member

commented Aug 3, 2018

@kenrowland Needs rebasing

@kenrowland kenrowland force-pushed the kenrowland:HPCC-20200 branch from 812e61d to 2f0d74c Aug 3, 2018

@kenrowland

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2018

@richardkchapman DON'T merge yet. Rebase missed a commit. Fixing...

@kenrowland kenrowland force-pushed the kenrowland:HPCC-20200 branch from 2f0d74c to 56b0f39 Aug 3, 2018

@kenrowland

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2018

@richardkchapman Ready for merge

@richardkchapman

This comment has been minimized.

Copy link
Member

commented Aug 4, 2018

@kenrowland Can you fix the commit message so it conforms to our conventions please

HPCC-20200 Improve attribute group processing
Improve processing of attribute groups

Signed-off-by: Ken Rowland <kenneth.rowland@lexisnexisrisk.com>

@kenrowland kenrowland force-pushed the kenrowland:HPCC-20200 branch from 56b0f39 to b14c7fa Aug 6, 2018

@kenrowland

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2018

@richardkchapman fixed. Please merge

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2018

Automated Smoketest:
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: b14c7fa
Build: success
Install hpccsystems-platform-community_7.0.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 89 89 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 804 804 0
test (thor) 729 729 0
test (roxie) 878 878 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
10 sec (00:00:10) 178 sec (00:02:58) 62 sec (00:01:02) 7 sec (00:00:07) 28 sec (00:00:28) 1317 sec (00:21:57) 19 sec (00:00:19) 1621 sec (00:27:01)

@richardkchapman richardkchapman merged commit 36cc6c8 into hpcc-systems:master Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.