Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-20431 Added curl to dependency list #11624

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
5 participants
@Michael-Gardner
Copy link
Contributor

commented Aug 30, 2018

Signed-off-by: Michael Gardner michael.gardner@lexisnexisrisk.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

Michael Gardner
HPCC-20431 Added curl to dependency list
Signed-off-by: Michael Gardner <michael.gardner@lexisnexisrisk.com>
@hpcc-jirabot

This comment has been minimized.

Copy link

commented Aug 30, 2018

@Michael-Gardner

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2018

@xwang2713 apparently zap can call a pipe that uses the curl utility. Just adding it as a dependency just in case it wasn't already on these systems by default.

@xwang2713
Copy link
Member

left a comment

Looks good

@Michael-Gardner

This comment has been minimized.

Copy link
Contributor Author

commented Aug 30, 2018

@richardkchapman ready for merge

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2018

Automated Smoketest:
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 972e173
Build: success
Install hpccsystems-platform-community_7.0.0-rc1.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 94 94 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 805 805 0
test (thor) 729 729 0
test (roxie) 878 878 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
20 sec (00:00:20) 175 sec (00:02:55) 93 sec (00:01:33) 19 sec (00:00:19) 42 sec (00:00:42) 1354 sec (00:22:34) 19 sec (00:00:19) 1722 sec (00:28:42)

@richardkchapman richardkchapman merged commit 05a3397 into hpcc-systems:master Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.