Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-12229 Improved graph progress colours #11634

Merged
merged 1 commit into from Sep 6, 2018
Merged

HPCC-12229 Improved graph progress colours #11634

merged 1 commit into from Sep 6, 2018

Conversation

GordonSmith
Copy link
Member

@GordonSmith GordonSmith commented Aug 31, 2018 •
edited

Signed-off-by: Gordon Smith gordonjsmith@gmail.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

@GordonSmith
HPCC-12229 Improved graph progress colours
7b32e79 
Signed-off-by: Gordon Smith <gordonjsmith@gmail.com>
@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-12229
Jira updated

@GordonSmith
Copy link
Member Author

@miguelvazq please review.

GordonSmith
GordonSmith commented Aug 31, 2018
View reviewed changes
esp/src/src/WUScopeController.ts
for (const key in sgColors) {
const sgColor = sgColors[key];
if (sgColor.total === sgColor.finished) {
// sgColor.sg.borderColor(...);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a placeholder until: hpcc-systems/Visualization#2829 has been completed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 7b32e79
Build: success
ECL Watch: Rebuilding Site
Install warning(s):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: phantomjs-prebuilt@2.1.16 (node_modules/jshint/node_modules/phantomjs-prebuilt):
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: phantomjs-prebuilt@2.1.16 install: node install.js
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: Exit status 1

Rebuild: success
Install hpccsystems-platform-community_7.0.0-rc1.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 94 94 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 805 805 0
test (thor) 729 729 0
test (roxie) 878 878 0

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
34 sec (00:00:34) 176 sec (00:02:56) 168 sec (00:02:48) 20 sec (00:00:20) 43 sec (00:00:43) 1331 sec (00:22:11) 19 sec (00:00:19) 1791 sec (00:29:51)

miguelvazq
miguelvazq approved these changes Sep 6, 2018
View reviewed changes
esp/src/src/WUScopeController.ts
for (const key in sgColors) {
const sgColor = sgColors[key];
if (sgColor.total === sgColor.finished) {
// sgColor.sg.borderColor(...);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@richardkchapman richardkchapman merged commit 2624c03 into hpcc-systems:master Sep 6, 2018
@GordonSmith GordonSmith deleted the HPCC-12229-GraphProgressVisuals branch September 6, 2018 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelvazq miguelvazq miguelvazq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@GordonSmith @hpcc-jirabot @HPCCSmoketest @miguelvazq @richardkchapman