Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-20120 Add support for multiple server queues in Activity view #11948

Merged

Conversation

Projects
None yet
5 participants
@GordonSmith
Copy link
Member

commented Nov 28, 2018

"SingletonData.updateData" had invalid logic (for a very long time).

Signed-off-by: Gordon Smith gordonjsmith@gmail.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Testing:

@GordonSmith GordonSmith requested a review from miguelvazq Nov 28, 2018

@hpcc-jirabot

This comment has been minimized.

Copy link

commented Nov 28, 2018

https://track.hpccsystems.com/browse/HPCC-20120
Jira not updated (user does not match)

@GordonSmith

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2018

@miguelvazq please review - can I suggest you test as well?

@miguelvazq

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

@GordonSmith Absolutely.

@miguelvazq

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

Early testing results Testing pausing dfuserver queue appears to have a problem. Queuename was never passed in.

HPCC-20120 Add support for multiple server queues in Activity view
"SingletonData.updateData" had invalid logic (for a very long time).

Signed-off-by: Gordon Smith <gordonjsmith@gmail.com>

@GordonSmith GordonSmith force-pushed the GordonSmith:HPCC-20120 branch from 6c56183 to 1e2c57e Nov 28, 2018

@miguelvazq

This comment has been minimized.

Copy link
Member

commented Nov 28, 2018

Top level queues are pausing and resuming as expected.

The priority and individual pause/resume operations seem to be enabled whenever clicking on a DFUWU that are in a paused queue. An exception "018-11-28 18:22:17 GMT: Cannot update Workunit Dxxxxxxx-2018" does get thrown back and then that behavior for promoting/demoting priority is disabled.

Update I did verify that in legacy we did not allow prioritizing items in a queue only running jobs so, the only issue here is the enabling of buttons at the tool bar that would let a user believe that the queue job now has individual pausing/resuming

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2018

Automated Smoketest:
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: 1e2c57e
Build: success
Build: success
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout
unittest 95 95 0 0 0
wutoolTest(Dali) 19 19 0 0 0
wutoolTest(Cassandra) 19 19 0 0 0

Regression test result:

phase total pass fail
setup (hthor) 11 11 0
setup (thor) 11 11 0
setup (roxie) 11 11 0
test (hthor) 808 808 0
test (thor) 732 732 0
test (roxie) 881 881 0

HPCC Stop: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
52 sec (00:00:52) 191 sec (00:03:11) 0 sec (00:00:00) 64 sec (00:01:04) 18 sec (00:00:18) 1489 sec (00:24:49) 21 sec (00:00:21) 1835 sec (00:30:35)

@richardkchapman richardkchapman merged commit 5201e18 into hpcc-systems:candidate-7.0.4 Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.