Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-21609 Return correct thor node type for spare node #12270

merged 1 commit into from Mar 12, 2019


Copy link

commented Mar 7, 2019

The existing ECLWatch shows thor spares as slaves because ESP does not
return correct thor node type for spare node.

Signed-off-by: wangkx

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)


  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected


The existing ECLWatch shows thor spares as slaves because ESP does not
return correct thor node type for spare node.

Signed-off-by: wangkx <>

This comment has been minimized.

Copy link

commented Mar 7, 2019


This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

@afishbeck please review.


This comment has been minimized.

Copy link

commented Mar 7, 2019

Automated Smoketest:
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: fac7f02
Build: success
Build: success
Install HPCC Platform
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout elaps
unittest 104 104 0 0 0 34 sec
wutoolTest(Dali) 19 19 0 0 0 3 sec
wutoolTest(Cassandra) 19 19 0 0 0 6 sec

Regression test result:

phase total pass fail elaps
setup (hthor) 11 11 0 25 sec (00:00:25)
setup (thor) 11 11 0 46 sec (00:00:46)
setup (roxie) 11 11 0 22 sec (00:00:22)
test (hthor) 819 819 0 247 sec (00:04:07)
test (thor) 744 744 0 603 sec (00:10:03)
test (roxie) 893 893 0 350 sec (00:05:50)

Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
34 sec (00:00:34) 196 sec (00:03:16) 0 sec (00:00:00) 2 sec (00:00:02) 17 sec (00:00:17) 1513 sec (00:25:13) 19 sec (00:00:19) 1781 sec (00:29:41)
Copy link

left a comment

@wangkx looks good.

@richardkchapman richardkchapman merged commit c96d45a into hpcc-systems:candidate-7.2.x Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
5 participants
You can’t perform that action at this time.