Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-22288 XREF widget needs numeric values "right-justified" #12639

Merged

Conversation

@kunalaswani
Copy link
Contributor

commented Jun 10, 2019

Numeric column values are now right justified in XREF section.

Signed-off-by: Aswani, Kunal kunal.aswani@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@hpcc-jirabot

This comment has been minimized.

Copy link

commented Jun 10, 2019

@kunalaswani

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

@GordonSmith please review, these files were missed in the right-justify PR previously.

Num: { label: this.i18n.Files, width: 30, sortable: false },
Size: { label: this.i18n.TotalSize, width: 30, sortable: false },
Num: { label: this.i18n.Files, width: 30, sortable: false,
renderCell: function (object, value, node, options) {

This comment has been minimized.

Copy link
@GordonSmith

GordonSmith Jun 11, 2019

Member

Rather than renderCell (which is a bit heavy), you can specify className: 'justify-right'

Numeric column values are now right justified in XREF section.

Signed-off-by: Aswani, Kunal <kunal.aswani@lexisnexis.com>
@kunalaswani kunalaswani force-pushed the kunalaswani:HPCC-22288 branch from 6ee219e to a4193a2 Jun 12, 2019
@kunalaswani

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

@GordonSmith changes made.

@HPCCSmoketest

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Automated Smoketest:
OS: centos 7.4.1708 (Linux 3.10.0-327.28.3.el7.x86_64)
Sha: a4193a2
Build: success
Build: success
Install HPCC Platform
HPCC Start: OK
HPCC Stop: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
41 sec (00:00:41) 211 sec (00:03:31) 0 sec (00:00:00) 49 sec (00:00:49) 19 sec (00:00:19) 0 sec (00:00:00) 13 sec (00:00:13) 333 sec (00:05:33)
Copy link
Member

left a comment

Looks good!

@richardkchapman richardkchapman merged commit d6b4c79 into hpcc-systems:candidate-7.2.x Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.