Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-23007 Files menu: file list, warning #13386

Merged
merged 1 commit into from Feb 24, 2020
Merged

HPCC-23007 Files menu: file list, warning #13386

merged 1 commit into from Feb 24, 2020

Conversation

kunalaswani
Copy link
Contributor

@kunalaswani kunalaswani commented Feb 20, 2020 •
edited

Filter Icon updated, along with new color change feature and hover to
display warning.

Signed-off-by: Kunal Aswani Kunal.Aswani@lexisnexisrisk.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@hpcc-jirabot
Copy link

https://track.hpccsystems.com/browse/HPCC-23007
Jira updated

@kunalaswani
Copy link
Contributor Author

@GordonSmith or @miguelvazq please review. I have created a documentation ticket as well should this need to be updated https://track.hpccsystems.com/browse/HPCC-23545

I have attached a screenshot so you can see what it will look like for users.

Thanks

filtericonwarn

miguelvazq
miguelvazq reviewed Feb 20, 2020
View reviewed changes
esp/src/eclwatch/FilterDropDownWidget.js Outdated
@@ -151,13 +151,15 @@ define([

refreshState: function () {
if (this.exists()) {
this.iconFilter.src = Utility.getImageURL("filter1.png");
this.iconFilter.style.color = "cornflowerblue";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did cornflowerblue come from? Does it match our currently color?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It matched better than the blue color, and it matched our current color.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguelvazq you can open a ticket to start relocating these into the new theme file so that they can get referenced by "concept" rather than specific color?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It matched better than the blue color, and it matched our current color.

Couldn't you match exactly using ColorZilla eye dropper tool to make sure we are consistent?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miguelvazq you can open a ticket to start relocating these into the new theme file so that they can get referenced by "concept" rather than specific color?

@GordonSmith @kunalaswani I will change these in our material-ui theme. And give them our palette treatment in there since the theme can support FA as well.

GordonSmith
GordonSmith approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me?

@kunalaswani
HPCC-23007 Files menu: file list, warning
4bac436 
Filter Icon updated, along with new color change feature and hover to
display warning.

Signed-off-by: Kunal Aswani <Kunal.Aswani@lexisnexisrisk.com>
@kunalaswani
Copy link
Contributor Author

@miguelvazq colors changed, exact match to blue, and icon alert changed to red as to match other elements. Please review.

@richardkchapman richardkchapman merged commit fc80778 into hpcc-systems:master Feb 24, 2020
@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.6.1810 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-16.ca-central-1.compute.internal
Sha: 4bac436
Build: success
Milestone:Install hpccsystems-platform-community_7.7.0-trunk0.el7.x86_64.rpm
HPCC Start: OK
HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
47 sec (00:00:47) 244 sec (00:04:04) 114 sec (00:01:54) 22 sec (00:00:22) 21 sec (00:00:21) 0 sec (00:00:00) 14 sec (00:00:14) 462 sec (00:07:42)

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.6.1810 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-17.ca-central-1.compute.internal
Sha: 4bac436
Build: success
Milestone:Install hpccsystems-platform-community_7.7.0-trunk0.el7.x86_64.rpm
HPCC Start: OK
HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
39 sec (00:00:39) 768 sec (00:12:48) 122 sec (00:02:02) 22 sec (00:00:22) 17 sec (00:00:17) 0 sec (00:00:00) 15 sec (00:00:15) 983 sec (00:16:23)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GordonSmith GordonSmith GordonSmith approved these changes

@miguelvazq miguelvazq miguelvazq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@kunalaswani @hpcc-jirabot @HPCCSmoketest @GordonSmith @miguelvazq @richardkchapman