Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-24418 Skews caused by child record doesn't work - remove #13994

Merged
merged 1 commit into from Jul 22, 2020

Conversation

shamser
Copy link
Contributor

@shamser shamser commented Jul 21, 2020

Signed-off-by: Shamser Ahmed shamser.ahmed@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Signed-off-by: Shamser Ahmed <shamser.ahmed@lexisnexis.com>
@hpcc-jirabot
Copy link

@shamser
Copy link
Contributor Author

shamser commented Jul 21, 2020

@ghalliday Unless we have more information, it will not be possible to determine that cause of a skew was child records.

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.6.1810 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-61.ca-central-1.compute.internal
Sha: f459a5a
Build: success
Milestone:Install hpccsystems-platform-community_7.10.7-closedown0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout elaps
unittest 144 144 0 0 0 75 sec
wutoolTest(Dali) 19 19 0 0 0 2 sec
wutoolTest(Cassandra) 19 19 0 0 0 8 sec

Regression test result:

phase total pass fail elaps
setup (hthor) 11 11 0 29 sec (00:00:29)
setup (thor) 11 11 0 43 sec (00:00:43)
setup (roxie) 11 11 0 19 sec (00:00:19)
test (hthor) 883 883 0 313 sec (00:05:13)
test (thor) 821 821 0 758 sec (00:12:38)
test (roxie) 962 962 0 408 sec (00:06:48)

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
10 sec (00:00:10) 765 sec (00:12:45) 119 sec (00:01:59) 23 sec (00:00:23) 18 sec (00:00:18) 1830 sec (00:30:30) 19 sec (00:00:19) 2784 sec (00:46:24)

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.8.2003 (Linux 3.10.0-957.1.3.el7.x86_64)
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Host: ip-10-20-0-116.ca-central-1.compute.internal
Sha: f459a5a
Build: success
Milestone:Install hpccsystems-platform-community_7.10.7-closedown0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout elaps
unittest 144 144 0 0 0 77 sec
wutoolTest(Dali) 19 19 0 0 0 1 sec
wutoolTest(Cassandra) 19 19 0 0 0 9 sec

Regression test result:

phase total pass fail elaps
setup (hthor) 11 11 0 32 sec (00:00:32)
setup (thor) 11 11 0 47 sec (00:00:47)
setup (roxie) 11 11 0 20 sec (00:00:20)
test (hthor) 883 883 0 585 sec (00:09:45)
test (thor) 821 821 0 1029 sec (00:17:09)
test (roxie) 962 962 0 723 sec (00:12:03)

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
11 sec (00:00:11) 1039 sec (00:17:19) 125 sec (00:02:05) 27 sec (00:00:27) 17 sec (00:00:17) 2720 sec (00:45:20) 18 sec (00:00:18) 3957 sec (01:05:57)

@ghalliday ghalliday merged commit de965d9 into hpcc-systems:candidate-7.10.x Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants