New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-24967 Add chart annotations based on chksum of configmap #14422
HPCC-24967 Add chart annotations based on chksum of configmap #14422
Conversation
https://track.hpccsystems.com/browse/HPCC-24967 |
94a73fe
to
aeefce0
Compare
@richardkchapman - if you could give this an initial review/feedback. Thanks. |
dec803e
to
01f6e9d
Compare
@@ -406,6 +406,12 @@ Check that the storage and spill planes for a component exist | |||
{{- end }} | |||
{{- end -}} | |||
|
|||
{{/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems (a) a bit small to be worth having a template for and (b) to be unused
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree, will remove.
01f6e9d
to
ecf5567
Compare
@richardkchapman - have squashed in the above change. |
helm/hpcc/templates/esp.yaml
Outdated
{{ range $.Values.esp -}} | ||
{{- if not .disabled -}} | ||
{{- $configSHA := include "hpcc.espConfigMap" (dict "root" $ "me" .) | sha256sum }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether a $scope "= dict "root" $ "me" . at the top of some of these would be helpful, as it's passed to a LOT of templates
helm/hpcc/templates/eclagent.yaml
Outdated
{{- include "hpcc.generateLoggingConfig" (dict "root" .root "me" .me) | indent 6 }} | ||
{{ $apptype }}: | ||
{{ toYaml (omit .me "logging") | indent 6 }} | ||
{{- include "hpcc.generateLoggingConfig" (dict "root" .root "me" .me) | indent 6 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this dict just "." ?
c13c1fe
to
d866698
Compare
@richardkchapman - have made changes to common up usages of root+me dict, and rebased/retargeted to master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - please squash
This will force the pods to recycle, if a config property relevant to a deployment changes. Signed-off-by: Jake Smith <jake.smith@lexisnexisrisk.com>
d866698
to
b673a0c
Compare
Process of PR-14422, label: hpcc-24967-configmap-annotate-chksum is skipped. |
@richardkchapman - squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
This will force the pods to recycle, if a config property
relevant to a deployment changes.
Signed-off-by: Jake Smith jake.smith@lexisnexisrisk.com
Type of change:
Checklist:
Smoketest:
Testing: