Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPCC-27260 Do not optimize away PREFETCH-PROJECT even if it is a nop #15841

Merged
merged 1 commit into from Mar 3, 2022

Conversation

ghalliday
Copy link
Member

@ghalliday ghalliday commented Mar 2, 2022

Signed-off-by: Gavin Halliday gavin.halliday@lexisnexis.com

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

@ghalliday ghalliday requested a review from shamser March 2, 2022 14:35
@ghalliday
Copy link
Member Author

Only a few examples are affected: bbraaten3a issue22783 khul5 slowkel2

@HPCCSmoketest
Copy link
Contributor

Automated Smoketest: ✅
OS: centos 7.6.1810 (Linux 3.10.0-957.1.3.el7.x86_64)
Host: ip-10-20-0-84.ca-central-1.compute.internal
GCC: gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5)
Git: 2.9.5, CMake: 3.22.1, cUrl: 7.67.0, node.js: v16.13.1, npm: 8.1.2
Sha: dfa4f8d
Containerized:False
Build: success
Milestone:Install hpccsystems-platform-community_8.7.0-trunk0.el7.x86_64.rpm
HPCC Start: OK

Unit tests result:

Test total passed failed errors timeout elaps
unittest 222 222 0 0 0 68 sec
wutoolTest(Dali) 19 19 0 0 0 1 sec

Regression test result:

phase total pass fail elaps
setup (hthor) 9 9 0 22 sec (00:00:22)
setup (thor) 9 9 0 39 sec (00:00:39)
setup (roxie) 19 19 0 18 sec (00:00:18)
test (hthor) 984 984 0 857 sec (00:14:17)
test (thor) 894 894 0 1037 sec (00:17:17)
test (roxie) 1053 1053 0 916 sec (00:15:16)

HPCC Stop: OK
HPCC Uninstall: OK
Time stats:

Prep time Build time Package time Install time Start time Test time Stop time Summary
17 sec (00:00:17) 433 sec (00:07:13) 105 sec (00:01:45) 21 sec (00:00:21) 17 sec (00:00:17) 1297 sec (00:21:37) 19 sec (00:00:19) 1909 sec (00:31:49)

@richardkchapman richardkchapman merged commit a28622f into hpcc-systems:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants