Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

gh-2187 hpcc-init fails to stop thor on Ubuntu 12.04 #2188

Merged
merged 1 commit into from

3 participants

@richardkchapman

There is a regression in the killall program in the current Ubuntu 12.04
distro's repositories, which prevents killall from working as advertised
on longer executable names.

See https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/970638

Testing suggests that providing a full pathname that the executable was launched
with, as opposed to just the tail name, will work around the issue.

Without this workaround, thor cannot be properly stopped on Ubuntu 12.04 systems.

Fixes gh-2187.

Signed-off-by: Richard Chapman rchapman@hpccsystems.com

@richardkchapman richardkchapman gh-2187 hpcc-init fails to stop thor on Ubuntu 12.04
There is a regression in the killall program in the current Ubuntu 12.04
distro's repositories, which prevents killall from working as advertised
on longer executable names.

See https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/970638

Testing suggests that providing a full pathname that the executable was launched
with, as opposed to just the tail name, will work around the issue.

Without this workaround, thor cannot be properly stopped on Ubuntu 12.04 systems.

Fixes gh-2187.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
293d227
@richardkchapman

@jakesmith @pschwartz Please review

@jakesmith
Collaborator

Looks fine.

@pschwartz

Looks good to me.

@richardkchapman richardkchapman merged commit 50c893e into from
@richardkchapman richardkchapman deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 30, 2012
  1. @richardkchapman

    gh-2187 hpcc-init fails to stop thor on Ubuntu 12.04

    richardkchapman authored
    There is a regression in the killall program in the current Ubuntu 12.04
    distro's repositories, which prevents killall from working as advertised
    on longer executable names.
    
    See https://bugs.launchpad.net/ubuntu/+source/psmisc/+bug/970638
    
    Testing suggests that providing a full pathname that the executable was launched
    with, as opposed to just the tail name, will work around the issue.
    
    Without this workaround, thor cannot be properly stopped on Ubuntu 12.04 systems.
    
    Fixes gh-2187.
    
    Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 initfiles/componentfiles/thor/stop_thor
View
4 initfiles/componentfiles/thor/stop_thor
@@ -44,7 +44,7 @@ if [ "$#" -lt "2" ] || [ "$2" != "keep_sentinel" ]; then
sleep 1
fi
-masterproc="thormaster_$THORNAME"
+masterproc="$instancedir/thormaster_$THORNAME"
while [ "`${PIDOF} $masterproc`" != "" ]
do
echo --------------------------
@@ -58,7 +58,7 @@ done
echo --------------------------
echo stopping thor slaves
-slaveproc="thorslave_$THORNAME"
+slaveproc="$instancedir/thorslave_$THORNAME"
if [ "$localthor" = "true" ]; then
killall -9 $slaveproc
else
Something went wrong with that request. Please try again.