HPCC-9632 - Uninitialized lastCycles #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira not updated (state was not active) |
|
@richardkchapman - please review |
| @@ -52,6 +52,7 @@ | |||
| ProcessSlaveActivity::ProcessSlaveActivity(CGraphElementBase *container) : CSlaveActivity(container), threaded("ProcessSlaveActivity", this) | |||
| { | |||
| processed = 0; | |||
| lastCycles = 0; | |||
There was a problem hiding this comment.
The commit message says it is totalCycles that was uninitialized...
There was a problem hiding this comment.
Corrected commit message.
'lastCycles' was left uninitialized until sink processes started If the progress serialization requested timings before the sink had started, totalMaxMs/totalMinMs timinigs would be wrong Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
richardkchapman
added a commit
that referenced
this pull request
Jul 9, 2013
HPCC-9632 - Uninitialized lastCycles Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'lastCycles' was left uninitialized until sink processes started
If the progress serialization requested timings before the sink
had started, totalMaxMs/totalMinMs timinigs would be wrong
Signed-off-by: Jake Smith jake.smith@lexisnexis.com